This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR libstdc++/60587
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "frs dot dumont at gmail dot com" <frs dot dumont at gmail dot com>
- Date: Wed, 19 Mar 2014 23:38:05 +0100
- Subject: Re: PR libstdc++/60587
- Authentication-results: sourceware.org; auth=none
- References: <20140319213903 dot GA23191 at redhat dot com> <20140319222844 dot GA19403 at redhat dot com>
Hi
> On 19/mar/2014, at 23:28, Jonathan Wakely <jwakely@redhat.com> wrote:
>
>> On 19/03/14 21:39 +0000, Jonathan Wakely wrote:
>> I think the safe thing to do is (as I suggested at the time) to have a
>> trait saying which iterator types refer to contiguous memory. Our
>> debug mode only supports our own containers, so the ones which are
>> contiguous are known. For 4.9.0 I think the right option is simply
>> to remove __foreign_iterator_aux3 and __foreign_iterator_aux4
>> completely. The fixed version of __foreign_iterator_aux2() can detect
>> when we have iterators referring to the same sequence, which is what
>> we really want to detect. That's what the attached patch does and what
>> I'm going to test.
>
> With my suggested change we get an XPASS for
> testsuite/23_containers/vector/debug/57779_neg.cc
>
> An __is_contiguous trait would solve that.
Funny, I thought we already had it...
Paolo