Re: [ada, build] host/target configuration

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

On Sun, 16 Mar 2014 09:32:33 +0100, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Thomas Schwinge <thomas@codesourcery.com> writes:

<http://news.gmane.org/find-root.php?message_id=%3C930D868B-5772-4F33-BB28-B878D40ED165%40adacore.com%3E>
was the final version of the patch, after Olivier had taken it over from
me.


> > --- gcc/ada/gcc-interface/Makefile.in
> > +++ gcc/ada/gcc-interface/Makefile.in
> > @@ -151,12 +151,15 @@ GCC_CFLAGS = $(INTERNAL_CFLAGS) $(T_CFLAGS) $(CFLAGS)
> >  program_transform_name =
> >  objdir = .
> >  
> > -target_alias=@target_alias@
> >  target=@target@
> > +target_cpu=@target_cpu@
> > +target_vendor=@target_vendor@
> > +target_os=@target_os@
> > +host_cpu=@host_cpu@
> > +host_vendor=@host_vendor@
> > +host_os=@host_os@
> >  xmake_file = @xmake_file@
> >  tmake_file = @tmake_file@
> > -host_canonical=@host@
> > -target_cpu_default=@target_cpu_default@
> 
> This is wrong, you are reintroducing PR ada/39172.  Installed as
> obvious.

Sorry for that.

> 	PR ada/39172
> 	* gcc-interface/Makefile.in (target_cpu_default): Revert
> 	2013-10-11 change.

> --- gcc/ada/gcc-interface/Makefile.in	(revision 208604)
> +++ gcc/ada/gcc-interface/Makefile.in	(working copy)
> @@ -159,6 +159,7 @@
>  host_cpu=@host_cpu@
>  host_vendor=@host_vendor@
>  host_os=@host_os@
> +target_cpu_default = @target_cpu_default@

It is not obvious to me (and neither was to Olivier as well as the patch
reviewers, as it seems) where the gcc/ada/gcc-interface/ code is using
this variable.  Is there a way for this to be made more explicit, so in
the future it won't get removed as unused, again?


GrÃÃe,
 Thomas

Attachment: pgp0nWP1GiiY2.pgp
Description: PGP signature