This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch,avr] Fix PR59396: Ignore leading '*' in warning generation for ISR names
- From: Denis Chertykov <chertykov at gmail dot com>
- To: Georg-Johann Lay <avr at gjlay dot de>
- Cc: Senthil Kumar Selvaraj <senthil_kumar dot selvaraj at atmel dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 13 Mar 2014 22:36:44 +0400
- Subject: Re: [patch,avr] Fix PR59396: Ignore leading '*' in warning generation for ISR names
- Authentication-results: sourceware.org; auth=none
- References: <5321B176 dot 4030505 at gjlay dot de> <20140313154126 dot GA17771 at atmel dot com> <5321EDCF dot 9080802 at gjlay dot de>
2014-03-13 21:41 GMT+04:00 Georg-Johann Lay <avr@gjlay.de>:
> Am 03/13/2014 04:41 PM, schrieb Senthil Kumar Selvaraj:
>
>> On Thu, Mar 13, 2014 at 02:24:06PM +0100, Georg-Johann Lay wrote:
>>>
>>>
>>> Problem is that the assembler name might or might not be prefixed by '*'
>>> depending on when TARGET_SET_CURRENT_FUNCTION is called.
>>>
>>> The change is just to fix wrong warning because the current
>>> implementation
>>> of TARGET_SET_CURRENT_FUNCTION /always/ skips the first char when the
>>> assembler name is set.
>>
>>
>> FWIW, there's default_strip_name_encoding (varasm.c), which does the same
>> thing, and is used by a couple of other targets.
>
>
> Yes, I know.
>
> But I would prefer targetm.strip_name_encoding then, even though avr does
> not implement it.
I'm prefer `targetm.strip_name_encoding' or `default_strip_name_encoding'.
May be `default_strip_name_encoding' is better because it's used in few ports.
Denis.