This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [GOOGLE] Writes annotation info in elf section.

From: Dehao Chen <dehao at google dot com>
To: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Wed, 12 Mar 2014 10:49:44 -0700
Subject: Re: [GOOGLE] Writes annotation info in elf section.
Authentication-results: sourceware.org; auth=none
References: <CAO2gOZUgGC9=Ris-gymwt2_Tt6S6G1Gh5zGEDgAOsrXvgDVUBA at mail dot gmail dot com> <CAHACq4rOg5t7P+8gkmy6+WK_zrCp0-jH6jof-B1m4o_jOugFrg at mail dot gmail dot com> <CAO2gOZViMSUemD3CPPa6yekKeE4peEcipoM-GxAn+98VB5e53A at mail dot gmail dot com>

Thanks Cary for the comments.

Patch updated, an also added a tool in contrib/ to dump the profile
annotation coverage.

Dehao
>
>
> On Wed, Mar 12, 2014 at 9:48 AM, Cary Coutant <ccoutant@google.com> wrote:
>>
>> +void autofdo_source_profile::write_annotated_count () const
>> +{
>> +  switch_to_section (get_section (
>> +      ".gnu.switches.text.annotation",
>> +      SECTION_DEBUG | SECTION_MERGE | SECTION_STRINGS | 1, NULL));
>>
>> I think it would be worth a comment explaining the point of setting
>> the SECTION_MERGE and SECTION_STRINGS flags, and why it works for this
>> section. Also, the "1" is clearer if you write is as "(SECTION_ENTSIZE
>> & 1)".
>>
>> -cary
>
>

Attachment: diff.txt
Description: Text document

References:
- [GOOGLE] Writes annotation info in elf section.
  - From: Dehao Chen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]