This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bug 59586


On Mon, Mar 10, 2014 at 03:23:22PM +0100, Tobias Grosser wrote:
> >+++ b/gcc/testsuite/gfortran.dg/graphite/graphite.exp
> >@@ -44,6 +44,7 @@ set interchange_files [lsort [glob -nocomplain
> >$srcdir/$subdir/interchange-*.\[f
> >  set scop_files        [lsort [glob -nocomplain
> >$srcdir/$subdir/scop-*.\[fF\]{,90,95,03,08} ] ]
> >  set run_id_files      [lsort [glob -nocomplain
> >$srcdir/$subdir/run-id-*.\[fF\]{,90,95,03,08} ] ]
> >  set vect_files        [lsort [glob -nocomplain
> >$srcdir/$subdir/vect-*.\[fF\]{,90,95,03,08} ] ]
> >+set parallelize_files [lsort [glob -nocomplain
> >$srcdir/$subdir/parallelize-all-*.\[fF\]{,90,95,03,08} ] ]
> >
> >  # Tests to be compiled.
> >  set dg-do-what-default compile
> >@@ -51,6 +52,7 @@ gfortran-dg-runtest $scop_files        "-O2 -fgraphite
> >-fdump-tree-graphite-all"
> >  gfortran-dg-runtest $id_files          "-O2 -fgraphite-identity
> >-ffast-math"
> >  gfortran-dg-runtest $interchange_files "-O2 -floop-interchange
> >-fno-loop-block -fno-loop-strip-mine -ffast-math -fdump-tree-graphite-all"
> >  gfortran-dg-runtest $block_files       "-O2 -floop-block
> >-fno-loop-strip-mine -fno-loop-interchange -ffast-math
> >-fdump-tree-graphite-all"
> >+gfortran-dg-runtest $parallelize_files "-Ofast  -floop-parallelize-all"
> 
> I am slightly surprised why this change is necessary. Roman, can you
> shade some light on this change.

I agree this is really horribly ugly.  Can't you just use
! { dg-additional-options "-Ofast -floop-parallelize-all" }
in the testcase?
I thought the ugliness of encoding options in test filenames was */vect/
only, apparently it affects also */graphite/ :(.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]