This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch RFC: Use internal qsort function in libbacktrace
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 4 Mar 2014 23:03:52 -0500
- Subject: Re: Patch RFC: Use internal qsort function in libbacktrace
- Authentication-results: sourceware.org; auth=none
- References: <mcrppm1mi78 dot fsf at iant-glaptop dot roam dot corp dot google dot com>
On Tue, Mar 4, 2014 at 10:34 PM, Ian Lance Taylor <iant@google.com> wrote:
> The GNU glibc qsort function will call malloc in some cases. That makes
> it unsuitable for libbacktrace, which is intended to work when called
> from a signal handler. This patch changes libbacktrace to use an
> internal qsort function.
>
> I'm posting this for comments in case anybody sees anything wrong with
> the implementation. I'll commit it in a day or two if I don't hear
> anything.
The first line of stest.c mentions "btest.c" instead of "stest.c":
/* btest.c -- Test for libbacktrace library