This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,GRAPHITE] Fix for P1 bug 58028
- From: Mircea Namolaru <mircea dot namolaru at inria dot fr>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>, Tobias Grosser <tobias at grosser dot es>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 27 Feb 2014 22:30:55 +0100 (CET)
- Subject: Re: [PATCH,GRAPHITE] Fix for P1 bug 58028
- Authentication-results: sourceware.org; auth=none
- References: <20140227094159 dot GA13605 at physik dot fu-berlin dot de> <yddy50w3lrt dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE>
Thanks for comments - updated the patch (fixed my e-mail address too :-)).
2014-02-26 Tobias Grosser <tobias@grosser.es>
Mircea Namolaru <mircea.namolaru@inria.fr>
Fix for bug 58028
* graphite-clast-to-gimple.c (set_cloog_options):
Don't remove scalar dimensions.
Index: gcc/graphite-clast-to-gimple.c
===================================================================
--- gcc/graphite-clast-to-gimple.c (revision 207298)
+++ gcc/graphite-clast-to-gimple.c (working copy)
@@ -1522,6 +1522,13 @@
variables. */
options->save_domains = 1;
+ /* Do not remove scalar dimensions. CLooG by default removes scalar
+ dimensions very early from the input schedule. However, they are
+ necessary to correctly derive from the saved domains
+ (options->save_domains) the relationship between the generated loops
+ and the schedule dimensions they are generated from. */
+ options->noscalars = 1;
+
/* Disable optimizations and make cloog generate source code closer to the
input. This is useful for debugging, but later we want the optimized
code.
----- Mail original -----
> De: "Rainer Orth" <ro@CeBiTec.Uni-Bielefeld.DE>
> À: "Tobias Burnus" <tobias.burnus@physik.fu-berlin.de>
> Cc: "Tobias Grosser" <tobias@grosser.es>, "Mircea Namolaru" <mircea.namolaru@inria.fr>, gcc-patches@gcc.gnu.org
> Envoyé: Jeudi 27 Février 2014 11:14:30
> Objet: Re: [PATCH,GRAPHITE] Fix for P1 bug 58028
>
> Tobias Burnus <tobias.burnus@physik.fu-berlin.de> writes:
>
> > On 02/26/2014 10:09 PM, Mircea Namolaru wrote:
> >> + /* Do not remove scalar dimensions. Cloog be default removes scalar
> >> + dimensions very early from the input schedule. However, they are
> >
> > Small nit: Instead of 'be default' it should be 'by default'
>
> ... and two spaces after the full stops. While you're at it, please fix
> the CLooG capitalization ;-)
>
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>