Re: [PATCH, GOMP4] Fix OpenACC async clause

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi Ilmir!

On Thu, 27 Feb 2014 13:55:36 +0400, Ilmir Usmanov <i.usmanov@samsung.com> wrote:
> Fixed patch and ChangeLog in attachment.

By the way, what I usually do is to put a change's ChangeLog snippet into
that Git commit's commit message, and then once I get to the point where
I push something upstream, I can just take it from there, and put it into
the respective ChangeLog file(s).  Just a suggestions -- no idea whether
that fits your workflow.


> On 27.02.2014 12:59, Thomas Schwinge wrote:
> > For consistency, also move OMP_CLAUSE_ASYNC_EXPR in gcc/tree.h, and also
> > adapt OMP_CLAUSE_ASYNC in gcc/tree-pretty-print.c:dump_omp_clause?
> It is already adapted:
> >     case OMP_CLAUSE_ASYNC:

Move between handling of OMP_CLAUSE_GANG and OMP_CLAUSE_ASYNC?

> 2014-02-27  Ilmir Usmanov  <i.usmanov@samsung.com>
> 
> 	Fix OpenACC ASYNC clause: it can contain integer-expression-list.

s%can%cannot, I think?

> 	* gcc/
> 	tree-core.h (enum omp_clause_code): Likewise.
> 	tree.h (OMP_CLAUSE_ASYNC_EXPR): Reorder.
> 	tree.c (omp_clause_num_ops, omp_clause_code_name): Reorder clauses.
> 	omp-low.c (scan_sharing_clauses): Likewise.
> 	gimplify.c (gimplify_scan_omp_clauses): Likewise.

Can't start that with ÂLikewise ;-), so change that or reorder the
entries.

With that changed, it's OK to commit (don't need to repost), thanks!


GrÃÃe,
 Thomas

Attachment: pgpAv0PYn4BOY.pgp
Description: PGP signature