This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR60179 - do not LTO stream DECL_FUNCTION_SPECIFIC_TARGET
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 14 Feb 2014 12:43:25 +0100
- Subject: Re: [PATCH] Fix PR60179 - do not LTO stream DECL_FUNCTION_SPECIFIC_TARGET
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1402141148190 dot 1593 at zhemvz dot fhfr dot qr>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Feb 14, 2014 at 11:51:43AM +0100, Richard Biener wrote:
> This removes streaming of cl_target_option (we can't stream
> pointers in it). The info was redundant given that we do stream
> the target attribute itself. So the following patch re-builds
> DECL_FUNCTION_SPECIFIC_TARGET at tree loading time (we need it
> during WPA inline analysis as well).
>
> LTO bootstrapped and tested on x86_64-unknown-linux-gnu, ok?
>
> (and yes, this fixes the libcpp/lex.o miscompare I was seeing
> with LTO bootstrap)
>
> The target hook implementations never use the 'name' or 'flags'
> arguments so I wonder if we should change its signature. That
> makes the values I pass to those args less arbitrary ;)
Looks good.
Jakub