This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [libgomp] make it possible to use OMP on both sides of a fork


> +/* This is to enable best-effort cleanup after fork.  */
> +static int gomp_we_are_forked = 0;

bool, no explicit initialization, possible removal, see below.

> +static void
> +gomp_free_thread_pool (int threads_running)

bool for threads_running.  It looks like a count otherwise.

> +gomp_after_fork_callback ()

 (void)

> +      pthread_atfork (NULL, NULL, &gomp_after_fork_callback);

& not needed.

Any reason not to just run gomp_free_thread_pool from gomp_after_fork_callback
directly?  I see no restrictions on what kind of code is allowed to execute
during that callback.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]