This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix for PR60080
- From: Jeff Law <law at redhat dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, Richard Biener <richard dot guenther at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 10 Feb 2014 09:39:46 -0700
- Subject: Re: [PATCH] Fix for PR60080
- Authentication-results: sourceware.org; auth=none
- References: <DUB129-W70BC2032E1B51A27097CFDE4970 at phx dot gbl>
On 02/07/14 04:00, Bernd Edlinger wrote:
Hi,
there has been a ICE on solaris 9 and 10 when dumping ASM_INPUT objects
without valid source loation at print-rtl.c.
print_rtx did not check for this, and tried to print NULL with printf format %s.
This happens to be handled by glibc's printf to print "(null)" but not on solaris.
Attached is my proposed patch for this: Firstly attaching the source location to
ASM_INPUT objects, that should not hurt, and secondly check for
UNKNOWN_LOCATION in print-rtl.c for ASM_INPUT and ASM_OPERANDS.
Boot-Strapped and Regression-tested on X86_64-linux-gnu.
Thanks
Bernd.
changelog-pr60080.txt
2014-02-06 Bernd Edlinger<bernd.edlinger@hotmail.de>
PR middle-end/60080
* cfgexpand.c (expand_asm_operands): Attach source location to
ASM_INPUT rtx objects.
* print-rtl.c (print_rtx): Check for UNKNOWN_LOCATION.
This is fine. Please install.
Thanks,
Jeff