This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: remove C_EXPR_APPEND macro
- From: Prathamesh Kulkarni <bilbotheelffriend at gmail dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
- Date: Sat, 8 Feb 2014 03:20:50 +0530
- Subject: Re: remove C_EXPR_APPEND macro
- Authentication-results: sourceware.org; auth=none
- References: <CAJXstsBgaw5gz3UYfO-UbQ=61Xvw5jvi8ngkkqAQxPtFFbwhVA at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1402072049340 dot 12232 at digraph dot polyomino dot org dot uk> <CAJXstsBL27WsvAQ-neEg_txSc8ytt5w7vExEwdLma2drKr8OZg at mail dot gmail dot com> <20140207213658 dot GT8907 at redhat dot com>
On Sat, Feb 8, 2014 at 3:06 AM, Marek Polacek <polacek@redhat.com> wrote:
> On Sat, Feb 08, 2014 at 02:51:03AM +0530, Prathamesh Kulkarni wrote:
>> On Sat, Feb 8, 2014 at 2:22 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
>> > On Sat, 8 Feb 2014, Prathamesh Kulkarni wrote:
>> >
>> >> This patch removes C_EXPR_APPEND macro in c-tree.h
>> >> OK for trunk ?
>> >
>> > Thanks, this is OK with the orphan comment "A varray of c_expr_t." also
>> > removed (please send the revised patch if you'd like someone to commit it
>> > for you).
>> Ah, I missed that, sorry.
>> Here's the revised patch:
>>
>> * c-parser.c (c_parser_get_builtin_args): replace calls to
>> C_EXPR_APPEND (cexpr_list, expr) by vec_safe_push (cexpr_list, expr)
>>
>> * c-tree.h (C_EXPR_APPEND): removed
>
> I'll fix up the CL and commit it for you. I suppose you tested this
> patch.
Yes, bootstrapped/reg tested on x86_64-linux-gnu
>
> Marek