This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch][AArch64] Shift right pattern fix
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Alex Velenko <Alex dot Velenko at arm dot com>
- Cc: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Thu, 6 Feb 2014 09:31:27 +0000
- Subject: Re: [Patch][AArch64] Shift right pattern fix
- Authentication-results: sourceware.org; auth=none
- References: <52EA6F8B dot 3020604 at arm dot com> <CAFqB+Pw4iTdaEwusSP6QB-PK=xe5H_TXE2N7ubnQTvoW00e7Nw at mail dot gmail dot com> <52EF7014 dot 8060703 at arm dot com>
On Mon, Feb 03, 2014 at 10:31:48AM +0000, Alex Velenko wrote:
> Hi,
> I agree to changelog change. Could this patch, please, be submitted as I
> do not have rights to do so.
> Kind regards,
> Alex
>
> On 30/01/14 22:36, Marcus Shawcroft wrote:
> > On 30 January 2014 15:28, Alex Velenko <Alex.Velenko@arm.com> wrote:
> >> Hi,
> >> This patch fixes shift right pattern, as it failed on -O0 after shift
> >> right patch. The reason was unnecessary movement of immediate value to
> >> a register due to type mismatch.
> >> Patch is tested not to cause any additional regressions.
> >> Could someone, please, approve and commit this patch, as I do not have
> >> the rights to do so?
> >>
> >> Kind regards,
> >> Alex
> >>
> >> 2014-01-28 Alex Velenko <Alex.Velenko@arm.com>
> >>
> >> gcc/
> >>
> >> * config/aarch64/aarch64-simd.md (aarch64_ashr_simddi): Fixed.
> >
> > Fixed doesn't say what was changed, how about:
> >
> > * config/aarch64/aarch64-simd.md (aarch64_ashr_simddi): Change QI to SI.
> >
> > OK with that change.
> > /Marcus
> >
>
>
I have committed this on Alex' behalf as revision 207531 with the
following ChangeLog entry:
2014-02-06 Alex Velenko <Alex.Velenko@arm.com>
* config/aarch64/aarch64-simd.md
(aarch64_ashr_simddi): Change QI to SI.
Thanks,
James