This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH i386 11/8] [AVX512] [1/2] Rename vmov* intrinsics according to EAS.
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 21 Jan 2014 16:15:00 +0100
- Subject: Re: [PATCH i386 11/8] [AVX512] [1/2] Rename vmov* intrinsics according to EAS.
- Authentication-results: sourceware.org; auth=none
- References: <20140114061303 dot GA57893 at msticlxl57 dot ims dot intel dot com> <CAFULd4aVig-4X7iCJyYO3XCxPn-+LDJF3ymUZt=0K2-0Zhk-bQ at mail dot gmail dot com> <20140121150731 dot GA34448 at msticlxl57 dot ims dot intel dot com>
On Tue, Jan 21, 2014 at 4:07 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>> > I have a doubts about changes to sse.md.
>> > I've splitted existing (SF-only) patterns into 2: DF and SF.
>> > As far as insn operands and final instruction have no such data
>> > type discrimination I set this data type to (mem:..) part.
>> > Having this (for SF):
>> > (define_expand "avx512pf_scatterpf<mode>sf"
>> > [(unspec
>> > [(match_operand:<avx512fmaskmode> 0 "register_or_constm1_operand")
>> > (mem:SF
>> > ...
>> >
>> > instead of this:
>> > (define_expand "avx512pf_scatterpf<mode>"
>> > [(unspec
>> > [(match_operand:<avx512fmaskmode> 0 "register_or_constm1_operand")
>> > (mem:<ssescalarmode>
>> > ...
>> >
>> > Not sure if this (DI/SI) mode for mem is needed. Moreover, not sure what
>> > that data type represents.
>>
>> Did you try to add DF/SF mode to the unspec? I am not familiar with
>> this insn, but shouldn't the mode of mem access be somehow similar to
>> the avx512f_scattersi<mode> access?
>>
>> Also, you can use double macroization with MODEF iterator for SF and DFmode.
>
> It seems that patch is (at last!) non-trivial, so I am splitting out trivial part
> in order to reduce volume.
>
> It is in the bottom.
>
> Bootstrapped, avx-512* tests pass, sse-* tests pass. Ok for trunk?
OK with a proper ChangeLog.
Thanks,
Uros.