This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PATCH]Improving mklog [was: Re: RFC Asan instrumentation control]
- From: Diego Novillo <dnovillo at google dot com>
- To: Tatiana Udalova <t dot udalova at samsung dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Slava Garbuzov <v dot garbuzov at samsung dot com>, Yury Gribov <y dot gribov at samsung dot com>
- Date: Fri, 17 Jan 2014 15:29:30 -0800
- Subject: Re: [PING][PATCH]Improving mklog [was: Re: RFC Asan instrumentation control]
- Authentication-results: sourceware.org; auth=none
- References: <009401cf1299$3ab96ac0$b02c4040$%udalova at samsung dot com>
Apologies for the delay. The patch is OK.
On Thu, Jan 16, 2014 at 12:59 AM, Tatiana Udalova <t.udalova@samsung.com> wrote:
> Ping!
>
> Thank you,
> Tatiana Udalova
>
>
> ----------
>
> Hello,
>
> I have reproduced the problem with mklog mentioned by Jakub:
>
>> In my experience mklog is pretty much useless, e.g. if you add a new
>> function, it will list the previous function as being modified rather
>> than the new one, etc.
>
> My focus was on functions from headers of diff-log chunks.
>
> I hacked a simple addition to mklog which skips unchanged functions in
> diff-log while adding function names to the final ChangeLog.
>
> New mklog results were verified by testsuite which compares reference
> ChangeLogs of patches from gcc trunk with logs generated by mklog.
>
> Patched mklog considerably reduced the number of unchanged functions in
> ChangeLog.
>
> Is it OK for trunk?
>
> Thank you,
> Tatiana Udalova
>
>