This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, cilk, C++] Fix cilk testsuite failure
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Steve Ellcey <sellcey at mips dot com>
- Cc: Andrew Pinski <pinskia at gmail dot com>, Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 17 Jan 2014 08:23:37 +0000
- Subject: Re: [Patch, cilk, C++] Fix cilk testsuite failure
- Authentication-results: sourceware.org; auth=none
- References: <5676f26c-f6d8-4798-8bdc-2b7b07f08925 at BAMAIL02 dot ba dot imgtec dot org> <CA+=Sn1nP_7xhjnPMH-HycXjX1Ze8O7fXFRc=tNxvHYFVO9RO6w at mail dot gmail dot com> <52D77276 dot 80201 at redhat dot com> <1389904644 dot 3022 dot 32 dot camel at ubuntu-sellcey> <CA+=Sn1kTAzjij3VfBq7Hxh1CSR3A1YMoy=DnzcC9RBiOo06JQQ at mail dot gmail dot com> <1389914554 dot 3022 dot 42 dot camel at ubuntu-sellcey> <CA+=Sn1=Ahm-J1jHux6xCYDSPtZKYEs3dPOzWnUqjh=Dt9f=7zA at mail dot gmail dot com> <1389917678 dot 3022 dot 45 dot camel at ubuntu-sellcey>
Steve Ellcey <sellcey@mips.com> writes:
> 2014-01-15 Andrew Pinski <apinski@cavium.com>
> Steve Ellcey <sellcey@mips.com>
>
> PR target/59462
> * config/mips/mips.c (mips_print_operand): Check operand mode instead
> of operator mode.
>
>
> diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
> index 617391c..60cb8ee 100644
> --- a/gcc/config/mips/mips.c
> +++ b/gcc/config/mips/mips.c
> @@ -8184,7 +8184,7 @@ mips_print_operand (FILE *file, rtx op, int letter)
> case 't':
> {
> int truth = (code == NE) == (letter == 'T');
> - fputc ("zfnt"[truth * 2 + (GET_MODE (op) == CCmode)], file);
> + fputc ("zfnt"[truth * 2 + (GET_MODE (XEXP (op, 0)) == CCmode)], file);
> }
> break;
>
I think it'd be more direct to check the register class, since we used
to store CCmode in GPRs too. I.e. ST_REGNO_P (XEXP (op, 0)).
OK with that change, thanks. Please backport to 4.8 too.
Richard
- References:
- [Patch, cilk, C++] Fix cilk testsuite failure
- Re: [Patch, cilk, C++] Fix cilk testsuite failure
- Re: [Patch, cilk, C++] Fix cilk testsuite failure
- Re: [Patch, cilk, C++] Fix cilk testsuite failure
- Re: [Patch, cilk, C++] Fix cilk testsuite failure
- Re: [Patch, cilk, C++] Fix cilk testsuite failure
- Re: [Patch, cilk, C++] Fix cilk testsuite failure
- Re: [Patch, cilk, C++] Fix cilk testsuite failure