This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google gcc-4_8] backport libgcov re-factoring patches from trunk
- From: Xinliang David Li <davidxl at google dot com>
- To: Rong Xu <xur at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 15 Jan 2014 10:40:04 -0800
- Subject: Re: [google gcc-4_8] backport libgcov re-factoring patches from trunk
- Authentication-results: sourceware.org; auth=none
- References: <CAF1bQ=T9RGivCJSJOzqq4U-P=jQU3_ZsqJo3P41AZefeELOOsw at mail dot gmail dot com>
In libgcov-driver.c,
1) there are couple of places with trailing white spaces (e.g, in
gcov_sort_n_vals body), please remove
2) gcov_exit_write_gcda in trunk takes eof_pos as an arg, and check it
before writing the header. I think this is more correct than in your
patch
3) It would be better to keep the function order the same in trunk
(e.g, compute summary related, merge gcda and write gcda etc); it is
also helpful to keep LIPO related functions order in the same way as
in google/main so that a better diff can be done
4) libdriver-profiler.c -- make the function ordering the same as in
google/main would be helpful.
thanks,
David
On Wed, Jan 15, 2014 at 10:03 AM, Rong Xu <xur@google.com> wrote:
> The attached patch backports libgcov re-factoring patches from trunk.
>
> Tested with google internal benchmarks, SPEC2006, bootstrap and
> profiledbootstrap.
>
> OK for google/gcc-4_8 branch?
>
> -Rong