This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR58115
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, Richard Biener <richard dot guenther at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, rdsandiford at googlemail dot com
- Date: Thu, 9 Jan 2014 11:24:49 +0100
- Subject: Re: [PATCH] Fix PR58115
- Authentication-results: sourceware.org; auth=none
- References: <87iotxv211 dot fsf at talisman dot default> <20140106103000 dot GG892 at tucnak dot redhat dot com> <f1eb6537-6c08-437c-9150-938fddf37d6e at email dot android dot com> <DUB122-W13171ACEDEEC745B906363E4B70 at phx dot gbl> <87eh4kvs2e dot fsf at talisman dot default> <DUB122-W3371E3A0858FA6FEE57114E4B70 at phx dot gbl> <87wqict2i0 dot fsf at talisman dot default> <CAFiYyc0gEjjFx530yxQKa2zQ40wYKZTgYpy+mzyzX6JSnNNzdQ at mail dot gmail dot com> <DUB122-W385E58BC9A893EE82EBF4DE4B00 at phx dot gbl> <87lhypsf2z dot fsf at talisman dot default>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Jan 09, 2014 at 09:02:28AM +0000, Richard Sandiford wrote:
> It looks like a correct fix, but the memcpy is going to be pretty
> expensive, since in most cases there will be no difference.
Perhaps we should add another tree code, which would represent the
combination of TARGET_OPTION_NODE and OPTIMIZATION_NODE, FUNCTION_DECL
would then refer to this combo node only and that new tree would
refer to both TARGET_OPTION_NODE and OPTIMIZATION_NODE.
That way we could stick the saved optabs into the new node rather than
having default opt cached target optabs, non-default opt with default
target optabs cached too, but for non-default target non-default opt we
don't cache anything and always recompute.
Or perhaps just merge both TARGET_OPTION_NODE and OPTIMIZATION_NODE
into one and let both target and optimize attributes adjust it?
Jakub