This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix for PR 59524
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Jeff Law <law at redhat dot com>
- Cc: "Iyer\, Balaji V" <balaji dot v dot iyer at intel dot com>, "gcc-patches\ at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "'Tobias Burnus \(burnus\ at net-b dot de\)'" <burnus at net-b dot de>
- Date: Thu, 09 Jan 2014 07:51:59 +0100
- Subject: Re: [PATCH] Fix for PR 59524
- Authentication-results: sourceware.org; auth=none
- References: <BF230D13CA30DD48930C31D4099330003A4B8CDF at FMSMSX101 dot amr dot corp dot intel dot com> <52CE2079 dot 3090704 at redhat dot com>
Jeff Law <law@redhat.com> writes:
>> gcc/testsuite/ChangeLog
>> +2014-01-08 Balaji V. Iyer <balaji.v.iyer@intel.com>
>> +
>> + PR testsuite/59524
>> + * gcc.dg/cilk-plus/cilk-plus.exp: Make sure the cilk keywords tests
>> + are run only if the Cilk library is available/enabled.
>> + * g++.dg/cilk-plus/cilk-plus.exp: Likewise.
>> + * lib/target-supports.exp (check_libcilkrts_available): New function.
>> +
>>
>> Is this Ok for trunk?
> Yes.
Better implement this as an effective-target keyword (cilkplus_runtime
to abstract from the library name?) so it's easily usable in individual
testcases if necessary, and document that in gcc/doc/sourcebuild.texi.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University