This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR49718 : allow no_instrument_function attribute in class member definition/declaration

From: Jeff Law <law at redhat dot com>
To: Laurent Alfonsi <laurent dot alfonsi at st dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Wed, 08 Jan 2014 22:02:19 -0700
Subject: Re: [PATCH] Fix PR49718 : allow no_instrument_function attribute in class member definition/declaration
Authentication-results: sourceware.org; auth=none
References: <52CD14C8 dot 5050305 at st dot com>

On 01/08/14 02:05, Laurent Alfonsi wrote:

     All,

I was looking at PR49718. I have enclosed a simple fix for this bug report.

2014-01-07  Laurent Alfonsi <laurent.alfonsi@st.com>

     * c-family/c-common.c (handle_no_instrument_function_attribute): Allow
       no_instrument_function attribute in class member
definition/declaration.


Looking at the implementation of the function attributes, I see no
reason anymore to keep this error message.
Let me know if I missed something.
I have also added a testcase in the enclosed patch.

2014-01-07  Laurent Alfonsi <laurent.alfonsi@st.com>

     PR c++/49718
     * g++.dg/pr49718.C: New

Isn't the idea here that if we've already generated the function body(presumably with instrumentation) that a no-instrument attributeappearing on a later declaration won't do anything useful?


jeff

Follow-Ups:
- Re: [PATCH] Fix PR49718 : allow no_instrument_function attribute in class member definition/declaration
  - From: Laurent Alfonsi

References:
- [PATCH] Fix PR49718 : allow no_instrument_function attribute in class member definition/declaration
  - From: Laurent Alfonsi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]