This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch,ARM] crypto intrinsics in AArch32 testsuite fix
- From: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 08 Jan 2014 15:22:14 +0000
- Subject: Re: [Patch,ARM] crypto intrinsics in AArch32 testsuite fix
- Authentication-results: sourceware.org; auth=none
- References: <CAKdteOZ11WJprVZm2CQc9gSSFOuS7moUZg91yyi7erZc+fD_4Q at mail dot gmail dot com>
On 08/01/14 15:00, Christophe Lyon wrote:
Hi,
Commit 206131 introduced check_effective_target_arm_crypto_ok in
lib/target-supports.exp, to check that the target supports
-mfpu=crypto-neon-fp-armv8 -mfloat-abi=softfp.
However, when GCC is configured for target arm-none-linux-gnueabihf, I
can see all the new tests fail:
sysroot-arm-none-linux-gnueabihf/usr/include/gnu/stubs.h:7:29: fatal
error: gnu/stubs-soft.h: No such file or directory
(stubs.h is included via arm_neon.h)
This is because check_effective_target_arm_crypto_ok sample test is
too simple. Making it include arm_neon.h does the trick (and makes the
tests UNSUPPORTED rather than FAIL).
OK?
Christophe.
Hi Christophe,
I believe the best solution here is to figure out the best mfloat-abi and mfpu
options combiation like we do for the NEON options (look for example at
check_effective_target_arm_neon_ok_nocache in target-supports.exp).
That way these tests will not add -mfloat-abi=softfp to an
arm-none-linux-gnueabihf target (which is the root of the problem) and they will
PASS instead of being just UNSUPPORTED.
I have a patch for that in testing.
Thanks,
Kyrill