This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: wide-int, rtl
- From: Mike Stump <mikestump at comcast dot net>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Kenneth Zadeck <zadeck at naturalbridge dot com>
- Date: Fri, 3 Jan 2014 12:28:08 -0800
- Subject: Re: wide-int, rtl
- Authentication-results: sourceware.org; auth=none
- References: <DA03AB53-E5E7-4B8D-9085-257FD158D7E8 at comcast dot net> <1673383 dot yVHhgiMuu2 at polaris> <20CE4C78-00CC-410E-98AB-A454B37E0FC9 at comcast dot net> <201401022326 dot 36915 dot ebotcazou at adacore dot com>
On Jan 2, 2014, at 2:26 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> So, I'd like to ping the original patch and Kenny's patch to resolve the
>> issues you found. If you have any other concerns or thoughts, let us
>> know.
>
> Almost OK, but remove the strange quotes in the comment for the INTEGER_CST
> case of expand_expr_real_1
Ok, thanks. I've resolved it this way:
Index: expr.c
===================================================================
--- expr.c (revision 206323)
+++ expr.c (working copy)
@@ -9477,11 +9477,10 @@ expand_expr_real_1 (tree exp, rtx target
return decl_rtl;
case INTEGER_CST:
- /* "Given that TYPE_PRECISION (type) is not always equal to
+ /* Given that TYPE_PRECISION (type) is not always equal to
GET_MODE_PRECISION (TYPE_MODE (type)), we need to extend from
the former to the latter according to the signedness of the
- type". */
-
+ type. */
temp = immed_wide_int_const (wide_int::from
(exp,
GET_MODE_PRECISION (TYPE_MODE (type)),