This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH i386 7/8] [AVX-512] Add tests.

From: Kirill Yukhin <kirill dot yukhin at gmail dot com>
To: Uros Bizjak <ubizjak at gmail dot com>
Cc: Richard Henderson <rth at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>, Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 30 Dec 2013 15:52:55 +0300
Subject: Re: [PATCH i386 7/8] [AVX-512] Add tests.
Authentication-results: sourceware.org; auth=none
References: <20131119103513 dot GI25998 at msticlxl57 dot ims dot intel dot com> <CAFULd4afgDMO9+0r9n6E3x907skxFvzqWt+HeHa6A5p4Jp3P5Q at mail dot gmail dot com> <20131120113044 dot GA41629 at msticlxl57 dot ims dot intel dot com> <20131202131838 dot GH2453 at msticlxl57 dot ims dot intel dot com> <20131218132342 dot GI57860 at msticlxl57 dot ims dot intel dot com> <CAFULd4ZYMbwpqwkdhgwu+8U8XDDTKxNkVePvHHDZVv8G6VTqWA at mail dot gmail dot com>

Hello UroÅ,
On 18 Dec 17:08, Uros Bizjak wrote:
> +/* { dg-do run } */
> +/* { dg-options "-O2 -mavx512cd -DHAVE_512 -DAVX512CD" } */
> +/* { dg-require-effective-target avx512cd } */
> +
> +#include "avx512f-helper.h"
> 
> Please put the definitions in the source itself, not in command line.
Done.

> +      if ((avx512f_os_support ()) && ((ebx & (bit_AVX512ER)) ==
> (bit_AVX512ER)))
> 
> No need for parenthesis around bit_* constants. They alredy have
> needed parenthesis in cpuid.h.
Done.

> +  src = *(int *) &source;
> 
> Strict aliasing violation.
> 
> +  dest = (sign << 31) | (exp << 23) | fraction;
> +  return *(float *) &dest;
> 
> also here.
I've passed whole my testsuite with -Wstrict-aliasing fixing viloations.

> The patch is otherwise OK for mainline, on the (obvious) condition
> that other patches get approved and committed first.

Thanks. I am testing patch (attached) and will check it in tomorrow if
testing will pass and no more inputs.

--
Thanks,K

Attachment: p.patch.bz2
Description: BZip2 compressed data

References:
- Re: [PATCH i386 7/8] [AVX-512] Add tests.
  - From: Kirill Yukhin
- Re: [PATCH i386 7/8] [AVX-512] Add tests.
  - From: Kirill Yukhin
- Re: [PATCH i386 7/8] [AVX-512] Add tests.
  - From: Uros Bizjak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]