This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH i386 4/8] [AVX512] [7/8] Add substed patterns: `round for expand' subst.
- From: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: Richard Henderson <rth at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>, Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 26 Dec 2013 12:47:45 +0300
- Subject: Re: [PATCH i386 4/8] [AVX512] [7/8] Add substed patterns: `round for expand' subst.
- Authentication-results: sourceware.org; auth=none
- References: <20130814074404 dot GE52726 at msticlxl57 dot ims dot intel dot com> <20131106072400 dot GD23881 at msticlxl57 dot ims dot intel dot com> <20131115170821 dot GF45205 at msticlxl57 dot ims dot intel dot com> <20131119091253 dot GF25998 at msticlxl57 dot ims dot intel dot com> <20131202131110 dot GD2453 at msticlxl57 dot ims dot intel dot com> <20131218130427 dot GD57860 at msticlxl57 dot ims dot intel dot com> <CAFULd4buyNxnfSj6G4j2QLLCvpAZzPim6kj3efkDxBEaSAhRrQ at mail dot gmail dot com>
Hello Uros,
On 23 Dec 17:46, Uros Bizjak wrote:
> This "round_expand_predicate" is the predicate substitution I was
> referred to in the review of 5/8. Please use it also in insn patterns,
> perhaps renamed as "round_predicate"
This is drawback of substs. We bind given subst attribute to given subst
strictly. So, this guy:
+(define_subst_attr "round_expand_predicate" "round_expand" "nonimmediate_operand" "register_operand")
is binded to "round_expand" (second argument of definition) subst and to it only.
That is way name is "round_expand...", it reflects subst it relates to.
For rest substs I'll introduce dedicated attributes.
--
Thanks, K