This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH i386 4/8] [AVX512] [7/8] Add substed patterns: `round for expand' subst.
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Cc: Richard Henderson <rth at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>, Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 23 Dec 2013 17:46:10 +0100
- Subject: Re: [PATCH i386 4/8] [AVX512] [7/8] Add substed patterns: `round for expand' subst.
- Authentication-results: sourceware.org; auth=none
- References: <20130814074404 dot GE52726 at msticlxl57 dot ims dot intel dot com> <20131106072400 dot GD23881 at msticlxl57 dot ims dot intel dot com> <20131115170821 dot GF45205 at msticlxl57 dot ims dot intel dot com> <20131119091253 dot GF25998 at msticlxl57 dot ims dot intel dot com> <20131202131110 dot GD2453 at msticlxl57 dot ims dot intel dot com> <20131218130427 dot GD57860 at msticlxl57 dot ims dot intel dot com>
On Wed, Dec 18, 2013 at 2:04 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello,
>
> On 02 Dec 16:11, Kirill Yukhin wrote:
>> Hello,
>> On 19 Nov 12:12, Kirill Yukhin wrote:
>> > Hello,
>> > On 15 Nov 20:08, Kirill Yukhin wrote:
>> > > > Is it ok for trunk?
>> > > Ping.
>> > Ping.
>> Ping.
> Ping.
>
> Rebased patch in the bottom.
This "round_expand_predicate" is the predicate substitution I was
referred to in the review of 5/8. Please use it also in insn patterns,
perhaps renamed as "round_predicate", as it is not exclusive to
expanders. As mentioned, predicates should mirror constraints as close
as possible.
OK with these changes,
Uros.