This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH i386 5/8] [AVX-512] Extend vectorizer hooks.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: Kirill Yukhin <kirill dot yukhin at gmail dot com>, Richard Henderson <rth at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 22 Dec 2013 13:52:15 +0100
- Subject: Re: [PATCH i386 5/8] [AVX-512] Extend vectorizer hooks.
- Authentication-results: sourceware.org; auth=none
- References: <20131112123633 dot GC34333 at msticlxl57 dot ims dot intel dot com> <20131115171026 dot GH45205 at msticlxl57 dot ims dot intel dot com> <20131119091456 dot GH25998 at msticlxl57 dot ims dot intel dot com> <20131202131304 dot GF2453 at msticlxl57 dot ims dot intel dot com> <20131218130754 dot GF57860 at msticlxl57 dot ims dot intel dot com> <CAFULd4a7KMHMXH18yN6sJkz-Yg3FO5fyPYzAwi7r-zQChuidAg at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sun, Dec 22, 2013 at 11:47:52AM +0100, Uros Bizjak wrote:
> * tree-vect-stmts.c (vectorizable_load): Support AVX512's gathers.
> * tree-vectorizer.h (MAX_VECTORIZATION_FACTOR): Extend for 512
> bit vectors.
>
> I assumed the same testing procedure as described in the original submission:
>
> Testing:
> 1. Bootstrap pass.
> 2. make check shows no regressions.
> 3. Spec 2000 & 2006 build show no regressions both with and without
> -mavx512f option.
> 4. Spec 2000 & 2006 run shows no stability regressions without
> -mavx512f option.
>
> The x86 part is OK for mainline. You will also need approval from the
> middle-end reviewer for tree-* parts.
The tree parts are ok for trunk, but likely insufficient by now,
you need similar changes for vectorizable_mask_load_store (which also
handles gathers), plus verify even the non-gather mask load/store if they
don't need any tweaking for AVX512F (integer masks rather than vector
ones?).
Jakub