This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] _Cilk_for for C and C++
- From: Jason Merrill <jason at redhat dot com>
- To: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>, "'Jeff Law'" <law at redhat dot com>, "'Aldy Hernandez'" <aldyh at redhat dot com>
- Cc: "'gcc-patches at gcc dot gnu dot org'" <gcc-patches at gcc dot gnu dot org>, "'rth at redhat dot com'" <rth at redhat dot com>, "'Jakub Jelinek'" <jakub at redhat dot com>
- Date: Mon, 16 Dec 2013 16:21:44 -0500
- Subject: Re: [PATCH] _Cilk_for for C and C++
- Authentication-results: sourceware.org; auth=none
- References: <BF230D13CA30DD48930C31D4099330003A49F0C1 at FMSMSX101 dot amr dot corp dot intel dot com> <52869727 dot 4060307 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4A8DA6 at FMSMSX101 dot amr dot corp dot intel dot com> <528F8A42 dot 1040704 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4AC599 at FMSMSX101 dot amr dot corp dot intel dot com> <52962687 dot 2020107 at redhat dot com> <52964B50 dot 6090006 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4AD05D at FMSMSX101 dot amr dot corp dot intel dot com> <529693B0 dot 4050005 at redhat dot com> <529D7A76 dot 1080001 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4AE391 at FMSMSX101 dot amr dot corp dot intel dot com> <BF230D13CA30DD48930C31D4099330003A4B2148 at FMSMSX101 dot amr dot corp dot intel dot com>
On 12/15/2013 07:40 PM, Iyer, Balaji V wrote:
- tree clauses, tree *cclauses)
+ tree clauses_or_grain, tree *cclauses)
Instead of this, please make the grainsize a new type of clause.
- return (gimple_omp_subcode (g) & GF_OMP_FOR_COMBINED) != 0;
+ return (gimple_omp_for_kind (g) == GF_OMP_FOR_COMBINED);
I don't really know this code, but this change seems unlikely to be
correct. Can you explain it?
+ tree data_name = get_identifier (".omp_data_i");
+ if (is_cilk_for)
+ data_name = get_identifier (".cilk_for_data_i");
Why does the name of an artificial parameter matter?
}
+/* A subroutine of expand_omp_for. Generate code for _Cilk_for loop.
+ Given parameters:
Need a blank line after the }.
Jason