This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] remove gate for ipa_inline pass
- From: Trevor Saunders <tsaunders at mozilla dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Mon, 16 Dec 2013 13:36:49 -0500
- Subject: Re: [patch] remove gate for ipa_inline pass
- Authentication-results: sourceware.org; auth=none
- References: <52AB6322 dot 4050108 at redhat dot com> <52AF26B5 dot 5050402 at redhat dot com>
On Mon, Dec 16, 2013 at 09:13:41AM -0700, Jeff Law wrote:
> On 12/13/13 12:42, Aldy Hernandez wrote:
> >I'm fixing something completely unrelated, and noticed this...
> >
> >Perhaps I'm missing something, but why do we need a gate when it always
> >returns true? Now that we have this `pass_data' business, we can set
> >has_gate to false.
> >
> >I also fixed a minor typo in a comment.
> Note that the way we handle pass properties differs when we have a
> gate vs no gate. See register_dump_files_1.
>
> I have no clue why we have that gem and it looks damn strange to me.
afaik that code is useless, I was going to remove it in
http://gcc.gnu.org/ml/gcc-patches/2013-11/msg00854.html but I didn't
finish fixing the issues with passes with an execute hook and child
passes before the end of stage 1 so the unrelated bits didn't get
committed yet.
Trev
>
> jeff