This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] remove gate for ipa_inline pass

From: Aldy Hernandez <aldyh at redhat dot com>
To: Jeff Law <law at redhat dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 16 Dec 2013 09:47:56 -0800
Subject: Re: [patch] remove gate for ipa_inline pass
Authentication-results: sourceware.org; auth=none
References: <52AB6322 dot 4050108 at redhat dot com> <52AF26B5 dot 5050402 at redhat dot com>

On 12/16/13 08:13, Jeff Law wrote:

On 12/13/13 12:42, Aldy Hernandez wrote:

I'm fixing something completely unrelated, and noticed this...

Perhaps I'm missing something, but why do we need a gate when it always
returns true?  Now that we have this `pass_data' business, we can set
has_gate to false.

I also fixed a minor typo in a comment.

Note that the way we handle pass properties differs when we have a gate
vs no gate.  See register_dump_files_1.

I have no clue why we have that gem and it looks damn strange to me.

jeff

Ughhh, that's just many shades of wrong. Alright, nice catch. I'llmove onto something else.


Thanks.

References:
- [patch] remove gate for ipa_inline pass
  - From: Aldy Hernandez
- Re: [patch] remove gate for ipa_inline pass
  - From: Jeff Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]