This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: New tsan tests.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- Cc: Yury Gribov <y dot gribov at samsung dot com>, Maxim Ostapenko <m dot ostapenko at partner dot samsung dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Slava Garbuzov <v dot garbuzov at samsung dot com>, Evgeny Gavrin <e dot gavrin at samsung dot com>, Konstantin Serebryany <kcc at gcc dot gnu dot org>
- Date: Wed, 11 Dec 2013 13:06:30 +0100
- Subject: Re: New tsan tests.
- Authentication-results: sourceware.org; auth=none
- References: <52A83A93 dot 7020903 at partner dot samsung dot com> <20131211102352 dot GD892 at tucnak dot redhat dot com> <52A846F2 dot 4060907 at samsung dot com> <20131211110719 dot GE892 at tucnak dot redhat dot com> <52A848AA dot 6070201 at samsung dot com> <CAGQ9bdwY+H17Rn_R4cR8Bdi-rkLbk2OoO16yskRPeGTRbzremQ at mail dot gmail dot com> <20131211112720 dot GF892 at tucnak dot redhat dot com> <CAGQ9bdyrJC47P18_ujHyitfGMHzNwQq-iu+r4n22SsF8opZLJA at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Dec 11, 2013 at 03:35:37PM +0400, Konstantin Serebryany wrote:
> >> when using what looks like the C subset).
> >
> > The question is why don't you limit to the subset of the two languages
> > when it doesn't cost anything.
>
> Mostly because of my (our) opinion above. :)
> GCC test suite may have more .c tests than .cc tests; I don't have an
> opinion here.
> We need some C++specific tests (e.g. with operator new) and we need at
> least one C test.
In the GCC testsuite, you can put tests that are written in the common
subset of C and C++ that you want to test by both frontends into
c-c++-common (they even can have different expected errors etc. through
{ target c } or { target c++ }), you can use #ifdef __cplusplus in the tests
too. Anyway, let's keep the current tests as is, the patch is ok for trunk,
and if in the future you wouldn't mind making more tests written in the
common subset of C/C++, it would be certainly appreciated.
Jakub