This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: "Gopalasubramanian, Ganesh" <Ganesh dot Gopalasubramanian at amd dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 11 Dec 2013 11:40:57 +0100
- Subject: Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4
- Authentication-results: sourceware.org; auth=none
- References: <EB4625145972F94C9680D8CADD6516155E73BF13 at SATLEXDAG02 dot amd dot com> <CAFULd4Y6XyUTZk0j2opkMQPWMp+U-pv0rN0NbJusffudEv00Fw at mail dot gmail dot com> <EB4625145972F94C9680D8CADD6516155E741F49 at SATLEXDAG02 dot amd dot com> <CAFULd4YcuD8-HaszKNPM2xvtjgu2BX0K4WGGRUE868fTv5OjzQ at mail dot gmail dot com> <EB4625145972F94C9680D8CADD6516155E764DAD at satlexdag04 dot amd dot com>
On Wed, Dec 11, 2013 at 11:27 AM, Gopalasubramanian, Ganesh
<Ganesh.Gopalasubramanian@amd.com> wrote:
> Accommodated the changes that you mentioned.
> Completed the bootstrap testing too.
Please provide updated ChangeLog.
The function comment is missing. Maybe you should also describe magic
number 32 here?
+static unsigned
+ix86_loop_unroll_adjust (unsigned nunroll, struct loop *loop)
+ if (!ix86_tune_features [X86_TUNE_ADJUST_UNROLL])
+ return nunroll;
Please add
#define TARGET_ADJUST_UNROLL \
ix86_tune_features[X86_TUNE_ADJUST_UNROLL]
to i386.h and use definition here.
Otherwise, the patch looks OK.
BTW: Please avoid top-posting, see e.g. [1] for reasons...
[1] http://gcc.gnu.org/ml/gcc/2008-08/msg00133.html
Uros.