This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: _Cilk_spawn and _Cilk_sync for C++


Hi Jason,
	Answers to your questions are given below.

> -----Original Message-----
> From: Jason Merrill [mailto:jason@redhat.com]
> Sent: Monday, December 9, 2013 2:41 PM
> To: Iyer, Balaji V; gcc-patches@gcc.gnu.org
> Cc: Jeff Law
> Subject: Re: _Cilk_spawn and _Cilk_sync for C++
> 
> On 12/05/2013 11:38 PM, Iyer, Balaji V wrote:
> > used the init_p value  that comes out of stabilize_expr
> 
> I guess you didn't look at the patch I sent you...
> 

Yes I saw it now. I am sorry for not removing it. It is removed now.

> Since you've fixed extract_free_variables, you don't need
> call_to_lambda_fn_p at all, or to call stabilize_expr.
> 

Yep.

> Why do you need to move add_variable_type, cilk_block_type and
> wrapper_data out of c-family/cilk.c?  You don't need to have the definition of
> wrapper_data available in order to cast a void* to a wrapper_data*.

Well, I was trying to fix this issue and was moving things back and forth and so I moved to the .h file. Now, I put it back in .c file.


Fixed patch and ChangeLog entries are attached. Is it Ok to install?

Thanks,

Balaji V. Iyer.
> 
> Jason

Attachment: diffe3.txt
Description: diffe3.txt

Attachment: ChangeLog.cilkplus-spawn-sync-c++
Description: ChangeLog.cilkplus-spawn-sync-c++


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]