Re: [patch] Fix gnat.dg/pack19.adb on some platforms

[Jeff Law <law at redhat dot com>]

On 12/09/13 16:17, Eric Botcazou wrote:
> > Ugh. I don't care that much :-)  If you want to handle it, go ahead.  I
> > would suggest a comment indicating why we've chosen to handle it.
>
> OK, I can do that.
>
> > The only question left is would it be better to handle it in
> > extract_bit_field to catch other cases, or is that too late?
>
> I put it there because there is a similar bitsize == 0 case just above:
>
> 	    if (ext_mode == BLKmode)
> 	      {
> 		if (target == 0)
> 		  target = assign_temp (type, 1, 1);
>
> 		if (bitsize == 0)
> 		  return target;
>
> Not clear how we can reach here though, I could add a comment if I find. :-)
:-)  From a cleanup standpoint, I think the expansion code is ripe for 
someone to spend (condsiderable) time killing dead code.  I suspect 
there's still significant gcc-1.91 (or even older) bits in there that 
have been dead for at least a decade.

Jeff