This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, RTL] Eliminate redundant vec_select moves.

From: Tejas Belagod <tbelagod at arm dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Sandiford <rdsandiford at googlemail dot com>
Date: Fri, 06 Dec 2013 11:36:39 +0000
Subject: Re: [Patch, RTL] Eliminate redundant vec_select moves.
Authentication-results: sourceware.org; auth=none
References: <527A7612 dot 2080406 at arm dot com> <877gcll9ht dot fsf at talisman dot default> <527BA073 dot 30900 at arm dot com> <87zjpg1d5p dot fsf at sandifor-thinkpad dot stglab dot manchester dot uk dot ibm dot com> <527BD411 dot 6060300 at arm dot com> <878uwwdnx0 dot fsf at talisman dot default> <52962733 dot 7030005 at arm dot com> <87r4a0c1ul dot fsf at talisman dot default> <529F5318 dot 1030505 at arm dot com> <CAMe9rOr9GqTEjfTPXB7gJLNRVkdjCZ_RMzWBOYFX8q4K8n=RJg at mail dot gmail dot com> <20131205223750 dot GB892 at tucnak dot redhat dot com>

Jakub Jelinek wrote:

On Wed, Dec 04, 2013 at 08:14:43AM -0800, H.J. Lu wrote:

--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/vect-nop-move.c
@@ -0,0 +1,64 @@
+/* { dg-do run } */
+/* { dg-require-effective-target vect_float } */
+/* { dg-options "-O3 -fdump-rtl-combine-details" } */


Please change dg-options to dg-additional-options, otherwise
it overrides the target basic vectorization options and thus
fails on i686-linux.

Sorry, OK I'll fix that. Also, curious to know what these fails look like - whatdefault options is this overriding to cause the fail(eg. this test doesn't needa cost model)?

+/* { dg-final { scan-rtl-dump "deleting noop move" "combine" { target
aarch64*-*-* } } } */

Any particular reason why it doesn't work for x86?

+/* { dg-final { cleanup-rtl-dump "combine" } } */


You also need to add

/* { dg-final { cleanup-tree-dump "vect" } } */


OK, will fix.

Thanks,
Tejas.

References:
- Re: [Patch, RTL] Eliminate redundant vec_select moves.
  - From: Tejas Belagod
- Re: [Patch, RTL] Eliminate redundant vec_select moves.
  - From: H.J. Lu
- Re: [Patch, RTL] Eliminate redundant vec_select moves.
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]