This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [buildrobot] score: Silence warnings to fix config-list.mk build


On 12/05/13 14:17, Jan-Benedict Glaw wrote:
Hi!

This patch silences warnings (unused static functions, ambiguous
`else') for the score target.

2013-12-05  Jan-Benedict Glaw  <jbglaw@lug-owl.de>

	* config/score/score.c (score_force_temporary): Delete function.
	(score_split_symbol): Ditto.
	* config/score/score.h (ASM_OUTPUT_ADDR_DIFF_ELT): Add extra
	parentheses to silence ambiguity warning.

[snip]

diff --git a/gcc/config/score/score.h b/gcc/config/score/score.h
index 5ab7875..e3bb7f0 100644
--- a/gcc/config/score/score.h
+++ b/gcc/config/score/score.h
@@ -757,11 +757,12 @@ typedef struct score_args
     entries PC-relative in GP-relative when .gp(d)word is supported.  */
  #define ASM_OUTPUT_ADDR_DIFF_ELT(STREAM, BODY, VALUE, REL)                \
    do {                                                                    \
-    if (TARGET_SCORE7)                                                    \
+    if (TARGET_SCORE7) {                                                  \
        if (flag_pic)                                                       \
          fprintf (STREAM, "\t.gpword %sL%d\n", LOCAL_LABEL_PREFIX, VALUE); \
        else                                                                \
          fprintf (STREAM, "\t.word %sL%d\n", LOCAL_LABEL_PREFIX, VALUE);   \
+    }                                                                     \
    } while (0)

  /* Jump table alignment is explicit in ASM_OUTPUT_CASE_LABEL.  */
Formatting nit. The open curley should be on its own line, indented 2 spaces relative to its conditional. Its close paren should also be on its own line at the same indention level as the open curley.

Note this will cause all the code inside the new curleys to need to be reindented as well.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]