This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libsanitizer merge from upstream r196489
- From: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: ÐÐÐÑÑÐÐ ÐÑÑÑÐÐÐÐ <dimhen at gmail dot com>, Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>, Dmitry Vyukov <dvyukov at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 5 Dec 2013 16:59:57 +0400
- Subject: Re: libsanitizer merge from upstream r196489
- Authentication-results: sourceware.org; auth=none
- References: <20131205105234 dot GA28738 at physik dot fu-berlin dot de> <CADJjh6mFuc3nJUJWik=W8XXkM4b5QUHoj2W_RcmMDzEZ7cPhsg at mail dot gmail dot com> <CAGQ9bdxe8nz6etVF1XoHvH-3+5nUTh6gWVcQxTiT=QzN1impWw at mail dot gmail dot com> <CAMe9rOpsESct7vA9V+a+KO2M9aKxR7JPqipx2nz1zUp8C6Wfvw at mail dot gmail dot com>
On Thu, Dec 5, 2013 at 4:47 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Dec 5, 2013 at 3:18 AM, Konstantin Serebryany
> <konstantin.s.serebryany@gmail.com> wrote:
>> On Thu, Dec 5, 2013 at 3:06 PM, ÐÐÐÑÑÐÐ ÐÑÑÑÐÐÐÐ <dimhen@gmail.com> wrote:
>>> clang' build is broken for me the same way
>>
>> Should be fixed now (only configure/make build was affected and I
>> tested the cmake build before committing)
>>
>>>
>>> Dmitry
>>>
>>> 2013/12/5 Tobias Burnus <tobias.burnus@physik.fu-berlin.de>:
>>>> Hi,
>>>>
>>>> On Thu, Dec 05, 2013 at 02:06:52PM +0400, Konstantin Serebryany wrote:
>>>>> Another libsanitizer merge from upstream, r196489
>>>>> (Quick follow up after the r196090 merge)
>>>>
>>>> That commit breaks the build with:
>>>>
>>>> In file included from ../../../../libsanitizer/tsan/tsan_rtl_report.cc:18:0:
>>>> ../../../../libsanitizer/tsan/tsan_rtl.h:29:44: fatal error: sanitizer_common/sanitizer_asm.h: No such file or directory
>>>> #include "sanitizer_common/sanitizer_asm.h"
>>>> ^
>>>> compilation terminated.
>>>>
>>>> Did you forgot to commit the new file?
>>
>> Looks like so, sorry. fixed by Jakub (
>> http://gcc.gnu.org/viewcvs?rev=205701&root=gcc&view=rev)
>>
>
> There are at least 2 fallouts:
>
> 1. -mx32 is broken.
Please send a patch to the llvm-commits list
> 2. libsanitizer now depends on libm:
Right... We've added -lm to clang's options recently.
>
> sanitizer_common/sanitizer_common_interceptors.inc:extern int signgam;
> sanitizer_common/sanitizer_common_interceptors.inc:
> COMMON_INTERCEPTOR_WRITE_RANGE(ctx, &signgam, sizeof(signgam));
> sanitizer_common/sanitizer_common_interceptors.inc:
> COMMON_INTERCEPTOR_WRITE_RANGE(ctx, &signgam, sizeof(signgam));
> sanitizer_common/sanitizer_common_interceptors.inc:
> COMMON_INTERCEPTOR_WRITE_RANGE(ctx, &signgam, sizeof(signgam));
>
> But -lm is added for -fsanitizer=address and I got
>
> configure:3158:
> /export/build/gnu/gcc-asan/build-x86_64-linux/./prev-gcc/xgcc
> -B/export/build/gnu/gcc-asan/build-x86_64-linux/./prev-gcc/
> -B/usr/local/x86_64-unknown-linux-gnu/bin/
> -B/usr/local/x86_64-unknown-linux-gnu/bin/
> -B/usr/local/x86_64-unknown-linux-gnu/lib/ -isystem
> /usr/local/x86_64-unknown-linux-gnu/include -isystem
> /usr/local/x86_64-unknown-linux-gnu/sys-include -o conftest -O2 -g
> -fsanitize=address -static-libstdc++ -static-libgcc
> -fsanitize=address -static-libasan
> -B/export/build/gnu/gcc-asan/build-x86_64-linux/prev-x86_64-unknown-linux-gnu/libsanitizer/
> -B/export/build/gnu/gcc-asan/build-x86_64-linux/prev-x86_64-unknown-linux-gnu/libsanitizer/asan/
> -B/export/build/gnu/gcc-asan/build-x86_64-linux/prev-x86_64-unknown-linux-gnu/libsanitizer/asan/.libs
> conftest.c >&5
> /export/build/gnu/gcc-asan/build-x86_64-linux/prev-x86_64-unknown-linux-gnu/libsanitizer/asan/.libs/libasan.a(asan_interceptors.o):
> In function `__interceptor_lgamma':
> /export/gnu/import/git/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:2762:
> undefined reference to `signgam'
> /export/build/gnu/gcc-asan/build-x86_64-linux/prev-x86_64-unknown-linux-gnu/libsanitizer/asan/.libs/libasan.a(asan_interceptors.o):
> In function `__interceptor_lgammaf':
>
>
>
> --
> H.J.