This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libsanitizer merge from upstream r196090
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, FX <fxcoudert at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- Date: Thu, 5 Dec 2013 09:58:33 +0100
- Subject: Re: libsanitizer merge from upstream r196090
- Authentication-results: sourceware.org; auth=none
- References: <72EBEFD0-CB56-4DCE-916A-EFBE449C3B62 at gmail dot com> <CAKOQZ8ywsNxj41Z3XXaxjmq=SSJ2zh6R-tNjdLvdPQCMMsGU_g at mail dot gmail dot com> <CAMe9rOr6Q+-J2X+iSN6o31HLr=Lmfw5zcowYhQh6RHQToMG4WA at mail dot gmail dot com>
On Wed, Dec 4, 2013 at 5:47 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Dec 4, 2013 at 8:41 AM, Ian Lance Taylor <iant@google.com> wrote:
>> On Wed, Dec 4, 2013 at 8:04 AM, FX <fxcoudert@gmail.com> wrote:
>>>> > Well, it regresses against 4.8, so it still is a P1 regression.
>>>>
>>>> Does anyone care?
>>>
>>>
>>> Well, you’re one of the maintainers of libsanitizer for GCC, so if you do not care about regressions in your code, it makes little sense for GCC (the whole project) to keep libsanitizer.
>>>
>>> I’ve posted this regression a month ago, it was not addressed. I’m not sure under what specific arrangement libsanitizer was added to GCC, but in general there is a responsibility of maintainers not to break bootstrap in their code. Yes, it’s a cost, and if you are not willing to do it, why did you contribute in the first place?
>>>
>>> Or is it a “hit and run” approach to maintainership?
>>
>> I believe this is a case where the GCC project gets more benefit from
>> libsanitizer than libsanitizer gets from being part of the GCC
>> project. We should work with the libsanitizer developers to make this
>> work, not just push everything back on them.
>>
>
> I think libsanitizer should be disabled automatically if kernel or glibc are
> too old.
>
> BTW, fixincludes should fix the bad kernel header files from SuSE.
Indeed - I'll give it a shot.
Richard.
>
> --
> H.J.