This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix force_to_mode not to modify in place the passed rtl (PR rtl-optimization/58726)
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Biener <rguenther at suse dot de>, Steven Bosscher <stevenb dot gcc at gmail dot com>
- Date: Wed, 04 Dec 2013 11:07:58 +0100
- Subject: Re: [PATCH] Fix force_to_mode not to modify in place the passed rtl (PR rtl-optimization/58726)
- Authentication-results: sourceware.org; auth=none
- References: <20131203224654 dot GH892 at tucnak dot redhat dot com>
> Fixed by making sure force_to_mode doesn't modify x in place.
I think that it's the way to go, force_to_mode doesn't modify its argument
except for these 2 cases. I'm not sure what the story is, but calling SUBST
for these 2 cases doesn't seem really necessary.
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.8?
>
> 2013-12-03 Jakub Jelinek <jakub@redhat.com>
>
> PR rtl-optimization/58726
> * combine.c (force_to_mode): Fix comment typo. Don't destructively
> modify x for ROTATE, ROTATERT and IF_THEN_ELSE.
>
> * gcc.c-torture/execute/pr58726.c: New test.
IMO it's the best fix at this point of the release cycles.
--
Eric Botcazou