This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR target/59363: [4.9 Regression] r203886 miscompiles git
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: Michael Zolotukhin <michael dot v dot zolotukhin at gmail dot com>, Uros Bizjak <ubizjak at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 3 Dec 2013 04:57:24 -0800
- Subject: Re: PATCH: PR target/59363: [4.9 Regression] r203886 miscompiles git
- Authentication-results: sourceware.org; auth=none
- References: <20131203010536 dot GA10039 at intel dot com> <CAFULd4ZgmC81w-34E4QNW-uCTyunOvBHRF55Dej=TzuawUkAsw at mail dot gmail dot com> <CANtU07-nGSSOmxAPxiAMP7U-84nW8YswF75CSy=36A2Fm4aqow at mail dot gmail dot com> <CAMe9rOqkmkvBVFQ-=80HqCPmD21kHXK-vqJMkPhgP+DpTWa2aA at mail dot gmail dot com> <20131203124141 dot GA3871 at kam dot mff dot cuni dot cz>
On Tue, Dec 3, 2013 at 4:41 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> Here is the updated patch. Tested on Linux/x86-64. It
>> fixed git. OK to install?
>>
>> Thanks.
>>
>> --
>> H.J.
>> ---
>> gcc/
>>
>> 2013-12-03 H.J. Lu <hongjiu.lu@intel.com>
>>
>> PR target/59363
>> * config/i386/i386.c (emit_memset): Adjust destination address
>> after gen_strset.
>> (expand_setmem_epilogue): Likewise.
>>
>> gcc/testsuite/
>>
>> 2013-12-03 H.J. Lu <hongjiu.lu@intel.com>
>>
>> PR target/59363
>> * gcc.target/i386/pr59363.c: New file.
>
> Yes, this seems fine to me. As discussed previously, we probably want to make
> strmov patterns use to match strset (I will need to re-check codegen on targets
> that does single memops) and then we will need similar update of aliasing
> there, too.
> Currently I assume we are fine becaue we use it only in expand_movmem epilogue
> and on the way there we already cleared the alias offset on all code paths?
>
I believe it is the case.
I checked it in.
Thanks.
--
H.J.