This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libsanitizer merge from upstream r196090
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>, Dodji Seketeli <dodji at redhat dot com>, Marek Polacek <polacek at redhat dot com>, Dmitry Vyukov <dvyukov at google dot com>, Evgeniy Stepanov <eugenis at google dot com>, Alexey Samsonov <samsonov at google dot com>
- Date: Tue, 3 Dec 2013 08:34:11 +0100
- Subject: Re: libsanitizer merge from upstream r196090
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4ZrFy-o7GmDh31WRpoxiYwwLpaAY6pOtxCZ9i-+4kfv1A at mail dot gmail dot com> <CAGQ9bdzMRvFOWXmAbRoXAM4otn6JMR8AALspJ1s=hP=jgm7KXQ at mail dot gmail dot com> <CAFULd4Z-HrnYedyH_fcH1knQAD+=4jmC_xOBacgs2-DJhGWD0Q at mail dot gmail dot com> <20131202164412 dot GN892 at tucnak dot redhat dot com> <CAGQ9bdwJ3nePVREarj06mSpAc40LDGC37TXUVcKjbtQ3VSKH+A at mail dot gmail dot com> <20131202223259 dot GQ892 at tucnak dot redhat dot com> <CAGQ9bdxV=SytJMmnhQGb7ycvDHtAq5So6u=vgRGLQ=AxJJZa6Q at mail dot gmail dot com>
On Tue, Dec 3, 2013 at 6:53 AM, Konstantin Serebryany
<konstantin.s.serebryany@gmail.com> wrote:
>>> >> with #if LINUX_VERSION_CODE >= 132640
>>> Good idea, let me try that.
>>
>> Had a quick look at this on RHEL 5.
>> Following patch let me compile at least the first source file, but then
>> I run into tons of issues in sanitizer_platform_limits_posix.cc.
>
> That's what I am afraid of. Even if we manage to compile everything,
> there is no guarantee that the code will work.
> I suggest to simply disable libsanitizer build on the older systems
> which is what happens de facto now.
> If there is significant interest in maintaining asan&co on older
> systems (which I have not seen so far),
> then those interested will need to help us in upstream repository (llvm) by
> a) sending us patches using http://llvm.org/docs/Phabricator.html and
> b) setting up a public buildbot (attached to the LLVM master bot) with
> the system they care about.
> If there is no one interested enough to do a) and b) I say we should
> not spend time on this.
IMO, it is also OK for the configure to check for needed features and
disable libsanitizer (perhaps with some informative message) if
minimum requirements are not met. If someone adds workarounds for
those missing features to support older systems, then chese checks can
easily be adapted. The problem ATM is, that gcc won't build
out-of-the-box on older distributions, although adding
--disable-libsanitizer manually works OK.
> And this discussion does not affect the merge since nothing that works
> today will get broken, right?
Yes, that's right.
Uros.