This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [patch] Fix PR middle-end/59138

From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
To: Eric Botcazou <ebotcazou at adacore dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>
Date: Sun, 1 Dec 2013 10:20:04 +0100
Subject: RE: [patch] Fix PR middle-end/59138
Authentication-results: sourceware.org; auth=none
References: <DUB122-W424CB6FE5529A0FF9AC8E6E4EE0 at phx dot gbl>,<3641857 dot E13Zc9z4mp at polaris>

Hi,

On Fri, 29 Nov 2013 12:28:15, Eric Botcazou wrote:
>
>> I think I see a small flaw in that patch:
>> + /* Make sure not to write past the end of the struct. */
>> + store_bit_field (dest,
>> + adj_bytelen * BITS_PER_UNIT, bytepos * BITS_PER_UNIT,
>> + bytepos * BITS_PER_UNIT, ssize * BITS_PER_UNIT,
>> + VOIDmode, tmps[i]);
>> the parameter BITREGION_END is wrong.
>> it should be:
>> ssize * BITS_PER_UNIT - 1
>
> This won't change anything since you cannot access one bit without accessing
> its unit but yes, it's more correct. Feel free to change it on both branches.
>
> --
> Eric Botcazou

Ok, committed as obvious, in both branches, after regression-testing.

Thanks
Bernd.

Attachment: patch-emit-group-store.diff
Description: Binary data

Follow-Ups:
- Re: [patch] Fix PR middle-end/59138
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]