This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING^2] [PATCH] PR59063
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Yury Gribov <y dot gribov at samsung dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, eugeni dot stepanov at gmail dot com, VandeVondele Joost <joost dot vandevondele at mat dot ethz dot ch>, Evgeny Gavrin <e dot gavrin at samsung dot com>, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>
- Date: Fri, 29 Nov 2013 09:48:18 -0800
- Subject: Re: [PING^2] [PATCH] PR59063
- Authentication-results: sourceware.org; auth=none
- References: <52831CF2 dot 1020203 at samsung dot com> <528C5453 dot 3020408 at samsung dot com> <529592F9 dot 3050209 at samsung dot com> <20131127071709 dot GV892 at tucnak dot redhat dot com> <5295F91E dot 8090407 at samsung dot com> <20131128083045 dot GM892 at tucnak dot redhat dot com> <52987367 dot 7000008 at samsung dot com> <20131129112216 dot GZ892 at tucnak dot redhat dot com> <52988934 dot 3030108 at samsung dot com> <CAMe9rOqx48ZRzop+5XZK7q00+oYVvzZWfG5x7aqCXzHEAB1ssg at mail dot gmail dot com> <CAMe9rOrdcxEXwq_aMpkMTCUCnD68MRwbsSLErgFtm1SAqjxRnw at mail dot gmail dot com> <CAMe9rOpi5=zAKGwhLmg6eW4F5jdq5ZdCPqMcT_HPLzYWpKmrqw at mail dot gmail dot com>
On Fri, Nov 29, 2013 at 9:06 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Nov 29, 2013 at 9:02 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Fri, Nov 29, 2013 at 8:47 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Fri, Nov 29, 2013 at 4:31 AM, Yury Gribov <y.gribov@samsung.com> wrote:
>>>>> Please fix up formatting
>>>>
>>>>> Also, isn't libsanitizer/libsanitizer.spec.in missing from the patch?
>>>>>
>>>>> Ok with that fixed.
>>>>
>>>> Thanks, r205524
>>>>
>>>
>>> On Linux/x86, I got
>>>
>>> FAIL: c-c++-common/asan/pr59063-2.c -O0 (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O0 (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O1 (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O1 (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O2 -flto -fno-use-linker-plugin
>>> -flto-partition=none (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O2 -flto -fno-use-linker-plugin
>>> -flto-partition=none (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O2 -flto -fuse-linker-plugin
>>> -fno-fat-lto-objects (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O2 -flto -fuse-linker-plugin
>>> -fno-fat-lto-objects (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O2 (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O2 (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O3 -fomit-frame-pointer (test
>>> for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O3 -fomit-frame-pointer (test
>>> for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O3 -g (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -O3 -g (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -Os (test for excess errors)
>>> FAIL: c-c++-common/asan/pr59063-2.c -Os (test for excess errors)
>>>
>>
>> This change
>>
>> diff --git a/gcc/testsuite/lib/asan-dg.exp b/gcc/testsuite/lib/asan-dg.exp
>> index e0bf2da..823265c 100644
>> --- a/gcc/testsuite/lib/asan-dg.exp
>> +++ b/gcc/testsuite/lib/asan-dg.exp
>> @@ -39,9 +39,9 @@ proc asan_link_flags { paths } {
>> set shlib_ext [get_shlib_extension]
>>
>> if { $gccpath != "" } {
>> + append flags " -B${gccpath}/libsanitizer/asan/ "
>> if { [file exists "${gccpath}/libsanitizer/asan/.libs/libasan.a"]
>> || [file exists
>> "${gccpath}/libsanitizer/asan/.libs/libasan.${shlib_ext}"] } {
>> - append flags " -B${gccpath}/libsanitizer/asan/ "
>> append flags " -L${gccpath}/libsanitizer/asan/.libs "
>> append ld_library_path ":${gccpath}/libsanitizer/asan/.libs"
>> }
>>
>> is wrong since
>>
>> [hjl@gnu-6 x86_64-unknown-linux-gnu]$ find libsanitizer -name libsanitizer.spec
>> libsanitizer/libsanitizer.spec
>> [hjl@gnu-6 x86_64-unknown-linux-gnu]$
>>
>
> I am checking in this as an obvious fix. Tested
> on Linux/x86.
>
> --
> H.J.
> --
> diff --git a/gcc/testsuite/lib/asan-dg.exp b/gcc/testsuite/lib/asan-dg.exp
> index 823265c..1e6c7dd 100644
> --- a/gcc/testsuite/lib/asan-dg.exp
> +++ b/gcc/testsuite/lib/asan-dg.exp
> @@ -39,9 +39,10 @@ proc asan_link_flags { paths } {
> set shlib_ext [get_shlib_extension]
>
> if { $gccpath != "" } {
> - append flags " -B${gccpath}/libsanitizer/asan/ "
> + append flags " -B${gccpath}/libsanitizer/ "
> if { [file exists "${gccpath}/libsanitizer/asan/.libs/libasan.a"]
> || [file exists
> "${gccpath}/libsanitizer/asan/.libs/libasan.${shlib_ext}"] } {
> + append flags " -B${gccpath}/libsanitizer/asan/ "
> append flags " -L${gccpath}/libsanitizer/asan/.libs "
> append ld_library_path ":${gccpath}/libsanitizer/asan/.libs"
I think bootstrap-asan.mk should also be updated.
--
H.J.