This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING^2] [PATCH] PR59063
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Yury Gribov <y dot gribov at samsung dot com>
- Cc: gcc-patches at gcc dot gnu dot org, eugeni dot stepanov at gmail dot com, VandeVondele Joost <joost dot vandevondele at mat dot ethz dot ch>, Evgeny Gavrin <e dot gavrin at samsung dot com>, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>
- Date: Fri, 29 Nov 2013 12:22:16 +0100
- Subject: Re: [PING^2] [PATCH] PR59063
- Authentication-results: sourceware.org; auth=none
- References: <52831CF2 dot 1020203 at samsung dot com> <528C5453 dot 3020408 at samsung dot com> <529592F9 dot 3050209 at samsung dot com> <20131127071709 dot GV892 at tucnak dot redhat dot com> <5295F91E dot 8090407 at samsung dot com> <20131128083045 dot GM892 at tucnak dot redhat dot com> <52987367 dot 7000008 at samsung dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Nov 29, 2013 at 02:58:47PM +0400, Yury Gribov wrote:
> --- a/gcc/testsuite/lib/asan-dg.exp
> +++ b/gcc/testsuite/lib/asan-dg.exp
> @@ -39,9 +39,9 @@ proc asan_link_flags { paths } {
> set shlib_ext [get_shlib_extension]
>
> if { $gccpath != "" } {
> + append flags " -B${gccpath}/libsanitizer/asan/ "
> if { [file exists "${gccpath}/libsanitizer/asan/.libs/libasan.a"]
> || [file exists "${gccpath}/libsanitizer/asan/.libs/libasan.${shlib_ext}"] } {
> - append flags " -B${gccpath}/libsanitizer/asan/ "
Please fix up formatting, if you move append flags outside of the
conditional, it needs to be indented the same as the if below it.
> append flags " -L${gccpath}/libsanitizer/asan/.libs "
> append ld_library_path ":${gccpath}/libsanitizer/asan/.libs"
> }
> diff --git a/gcc/testsuite/lib/ubsan-dg.exp b/gcc/testsuite/lib/ubsan-dg.exp
> index 4ec5fdf..b7f2b17 100644
> --- a/gcc/testsuite/lib/ubsan-dg.exp
> +++ b/gcc/testsuite/lib/ubsan-dg.exp
> @@ -30,9 +30,9 @@ proc ubsan_link_flags { paths } {
> set shlib_ext [get_shlib_extension]
>
> if { $gccpath != "" } {
> + append flags " -B${gccpath}/libsanitizer/ubsan/ "
> if { [file exists "${gccpath}/libsanitizer/ubsan/.libs/libubsan.a"]
> || [file exists "${gccpath}/libsanitizer/ubsan/.libs/libubsan.${shlib_ext}"] } {
> - append flags " -B${gccpath}/libsanitizer/ubsan/ "
Likewise.
Also, isn't libsanitizer/libsanitizer.spec.in missing from the patch?
Ok with that fixed.
Jakub