This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2] libgcc: AArch64: Check for correct signal insns on BE when unwinding
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Leach <matthew dot leach at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "pinskia at gmail dot com" <pinskia at gmail dot com>
- Date: Thu, 28 Nov 2013 10:59:49 +0000
- Subject: Re: [PATCH v2] libgcc: AArch64: Check for correct signal insns on BE when unwinding
- Authentication-results: sourceware.org; auth=none
- References: <1385548984-24298-1-git-send-email-matthew dot leach at arm dot com>
On 27/11/13 10:43, Matthew Leach wrote:
> Hi,
>
> When unwinding the stack, the unwind code checks for two opcodes that
> denote a registrations of a signal handler. This is broken on BE as
> the opcodes will be in the wrong byte-order as insns are always LE.
>
> Add the correct checks when compiling for AArch64 big endian.
>
> This patch fixes all glibc backtrace tests and causes no other
> regressions on glibc.
>
> Please note that I don't have commit access, if this is OK could
> someone merge it for me?
>
> Thanks,
> Matt Leach
>
> libgcc/
> 2013-11-26 Matthew Leach <matthew.leach@arm.com>
>
> * config/aarch64/linux-unwind.h (aarch64_fallback_frame_state):
> Check for correct opcodes on BE.
>
Thanks, I've put this in.
R.