This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING^2] [PATCH] PR59063
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Yury Gribov <y dot gribov at samsung dot com>
- Cc: gcc-patches at gcc dot gnu dot org, eugeni dot stepanov at gmail dot com, VandeVondele Joost <joost dot vandevondele at mat dot ethz dot ch>, Evgeny Gavrin <e dot gavrin at samsung dot com>, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>
- Date: Thu, 28 Nov 2013 09:30:46 +0100
- Subject: Re: [PING^2] [PATCH] PR59063
- Authentication-results: sourceware.org; auth=none
- References: <52831CF2 dot 1020203 at samsung dot com> <528C5453 dot 3020408 at samsung dot com> <529592F9 dot 3050209 at samsung dot com> <20131127071709 dot GV892 at tucnak dot redhat dot com> <5295F91E dot 8090407 at samsung dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Nov 27, 2013 at 05:52:30PM +0400, Yury Gribov wrote:
> > Perhaps it is time for libsanitizer.spec filled in during
> configure of libsanitizer
> > that the spec would source in?
>
> Draft patch is attached, let's see if I understood your
> recommendation correctly. Some obvious quirks:
> 1) I didn't add link_libubsan/link_liblsan because they seem to be
> happy with default libs from %(link_sanitizer).
> 2) I left LIBASAN_EARLY_SPEC/LIBASAN_SPEC logic in gnu-user.h and gcc.c
> because they rely on LD_STATIC_OPTION and HAVE_LD_STATIC_DYNAMIC
> which are defined in gcc/configure
> and thus not available in libsanitizer/configure.
Looks basically ok, my preference perhaps would be not to put
link_sanitizer into the Makefile*/libsanitizer.spec/gcc.c at all,
instead use it solely as configure.ac/configure internal variable
and set all of link_{a,t,l,ub}san to it plus the extra libs needed
by each of those. The fact that they have some common libs is IMHO just an
internal detail that doesn't need to be exposed outside of libsanitizer.
> + " %{static-libasan:%:include(libsanitizer.spec)%(link_libasan) %(link_sanitizer)}"
So this would have s/ %(link_sanitizer)//.
> + " %{static-liblsan:%:include(libsanitizer.spec) %(link_sanitizer)}"
Note for asan you didn't use space between %:include and %(link_*, but now
you did.
Jakub