This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: _Cilk_spawn and _Cilk_sync for C++

From: Jason Merrill <jason at redhat dot com>
To: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Cc: Jeff Law <law at redhat dot com>
Date: Wed, 27 Nov 2013 12:42:50 -0500
Subject: Re: _Cilk_spawn and _Cilk_sync for C++
Authentication-results: sourceware.org; auth=none
References: <BF230D13CA30DD48930C31D4099330003A4A696B at FMSMSX101 dot amr dot corp dot intel dot com> <528E57DE dot 90900 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4AA318 at FMSMSX101 dot amr dot corp dot intel dot com> <528F7D81 dot 4000308 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4AC201 at FMSMSX101 dot amr dot corp dot intel dot com>

On 11/25/2013 10:50 AM, Iyer, Balaji V wrote:

I have fixed this issue.  My function to map the variable's context from the spawner to the spawn helper function was going into the lambda function. I made it stop by adding a language specific copy_tree_body (basically stop going into the lambda function's body for C++ and for the rest of the times just use copy_tree_body_r, no code duplicating  is done between the two) that and it works fine now.

I doubt it was walking from the enclosing function into the body of thelambda function. Looking at the patch, it seems that what you'reavoiding is walking into the closure object itself, and adding an entirenew langhook seems like overkill for that.

I think a better approach would be to add a cp_build_cilk_spawn thatuses stabilize_call to pre-evaluate the arguments of the call.


Jason

Follow-Ups:
- RE: _Cilk_spawn and _Cilk_sync for C++
  - From: Iyer, Balaji V

References:
- _Cilk_spawn and _Cilk_sync for C++
  - From: Iyer, Balaji V
- Re: _Cilk_spawn and _Cilk_sync for C++
  - From: Jason Merrill
- RE: _Cilk_spawn and _Cilk_sync for C++
  - From: Iyer, Balaji V
- Re: _Cilk_spawn and _Cilk_sync for C++
  - From: Jason Merrill
- RE: _Cilk_spawn and _Cilk_sync for C++
  - From: Iyer, Balaji V

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]