This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AArch64] vmov_n changes
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- Cc: Alex Velenko <Alex dot Velenko at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Fri, 22 Nov 2013 15:41:03 +0000
- Subject: Re: [PATCH][AArch64] vmov_n changes
- Authentication-results: sourceware.org; auth=none
- References: <528DFDC5 dot 3070106 at arm dot com> <CAFqB+PzEHXL-YeeRqLDuEZNztY72j30Y0nr6nvCgQRX5wCtnRQ at mail dot gmail dot com>
On Fri, Nov 22, 2013 at 03:19:35PM +0000, Marcus Shawcroft wrote:
> 2013/11/21 Alex Velenko <Alex.Velenko@arm.com>:
>
> > 2013-11-21 Alex Velenko <Alex.Velenko@arm.com>
> >
> > * config/aarch64/arm_neon.h (vmov_n_f32): Implemented in C.
> > (vmov_n_f64): Likewise.
> > (vmov_n_p8): Likewise.
> > (vmov_n_p16): Likewise.
> > (vmov_n_s8): Likewise.
> > (vmov_n_s16): Likewise.
> > (vmov_n_s32): Likewise.
> > (vmov_n_s64): Likewise.
> > (vmov_n_u8): Likewise.
> > (vmov_n_u16): Likewise.
> > (vmov_n_u32): Likewise.
> > (vmov_n_u64): Likewise.
> > (vmovq_n_f32): Likewise.
> > (vmovq_n_f64): Likewise.
> > (vmovq_n_p8): Likewise.
> > (vmovq_n_p16): Likewise.
> > (vmovq_n_s8): Likewise.
> > (vmovq_n_s16): Likewise.
> > (vmovq_n_s32): Likewise.
> > (vmovq_n_s64): Likewise.
> > (vmovq_n_u8): Likewise.
> > (vmovq_n_u16): Likewise.
> > (vmovq_n_u32): Likewise.
> > (vmovq_n_u64): Likewise.
> >
> > gcc/testsuite/
> >
> > 2013-11-21 Alex Velenko <Alex.Velenko@arm.com>
> >
> > * gcc.target/aarch64/vmov_n_1.c: New testcase.
>
> OK, Thanks /Marcus
>
Thanks Marcus,
I've committed this on Alex' behalf as revision 205270 as he does
not have commit rights.
Alex, for future reference, your ChangeLog format is not correct.
There should be one tab at the beginning of each line.
Additionally, your patch did not trivially apply - I had issues
with the hunk adding a new test case. Perhaps you need to check
the settings on your mailer?
Thanks,
James