This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Builtins handling in IVOPT
- From: Wei Mi <wmi at google dot com>
- To: Zdenek Dvorak <rakdver at iuuk dot mff dot cuni dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>, David Li <davidxl at google dot com>
- Date: Thu, 21 Nov 2013 10:30:35 -0800
- Subject: Re: [PATCH] Builtins handling in IVOPT
- Authentication-results: sourceware.org; auth=none
- References: <CA+4CFy7_1JO7r3eq8TWzotR1L6oGKkecZx24OvBd8yeXKcshWQ at mail dot gmail dot com> <20131121081913 dot GB23315 at kam dot mff dot cuni dot cz>
On Thu, Nov 21, 2013 at 12:19 AM, Zdenek Dvorak
<rakdver@iuuk.mff.cuni.cz> wrote:
> Hi,
>
>> This patch works on the intrinsic calls handling issue in IVOPT mentioned here:
>> http://gcc.gnu.org/ml/gcc-patches/2010-10/msg01295.html
>>
>> In find_interesting_uses_stmt, it changes
>>
>> arg = expr
>> __builtin_xxx (arg)
>>
>> to
>>
>> arg = expr;
>> tmp = addr_expr (mem_ref(arg));
>> __builtin_xxx (tmp, ...)
>
> this looks a bit confusing (and wasteful) to me. It would make more sense to
> just record the argument as USE_ADDRESS and do the rewriting in rewrite_use_address.
>
> Zdenek
My intention was to use find_interesting_uses_address directly. But
you are right, the logic looks better to only do the rewriting in
rewrite_use_address. I will change here.
Thanks,
Wei.