This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Privatize gimplify_ctx structure.
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Andrew MacLeod <amacleod at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>, Diego Novillo <dnovillo at google dot com>
- Date: Wed, 20 Nov 2013 15:18:07 +0100
- Subject: Re: [patch] Privatize gimplify_ctx structure.
- Authentication-results: sourceware.org; auth=none
- References: <528CBAA0 dot 5060801 at redhat dot com> <CAFiYyc00hQJL3t2S8hw96HC+tp9T6B8mcFzTXQduaQG5F8nQag at mail dot gmail dot com> <20131120141658 dot GJ892 at tucnak dot redhat dot com>
On Wed, Nov 20, 2013 at 3:16 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Nov 20, 2013 at 03:12:34PM +0100, Richard Biener wrote:
>> The limit looks reasonable, but you could have used a simple linked
>> list (and never free). Also being able to pop a random context
>> looks fragile ... that is, pop_gimplify_context shouldn't have an argument.
>
> Can't we use stack_vec<gimplify_context, 30> for that? Though that would
> mean a global var constructor and destructor, so alternatively just use
> a normal vec and .create(30) it somewhere during initialization?
only with gimplify_context *, otherwise things will break during re-allocation.
Richard.
> Jakub