This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [x86,PATCH] Additional fix for 57756.
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Yuri Rumyantsev <ysrumyan at gmail dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Sriraman Tallam <tmsriram at google dot com>
- Date: Tue, 19 Nov 2013 14:48:04 +0100
- Subject: Re: [x86,PATCH] Additional fix for 57756.
- Authentication-results: sourceware.org; auth=none
- References: <CAEoMCqSAkHGFa5xdZSb0XY7N7oFHU6T05rK2Nc+xn321n-NV=w at mail dot gmail dot com> <CAMe9rOrkqsm2aEP9XdUHAeekT_J9i__V6iJJe6_dNWhAhB9zGA at mail dot gmail dot com> <CAEoMCqRQtswk1U_PQ8CMM=NiRjBAD-KnJEJ5FPADV-sEgegtLQ at mail dot gmail dot com>
On Tue, Nov 19, 2013 at 2:45 PM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote:
> Resend modified ChangeLog:
>
> 2013-11-20 Yuri Rumyantsev <ysrumyan@gmail.com>
> PR target/57756
> * config/i386/i386.c (ix86_option_override_internal): Add missed
> argument prefix for 'ix86_fpmath'.
> * config/i386/ssemath.h: Add missed definition of
> TARGET_FPMATH_DEFAULT_P macros.
>
> 2013/11/19 H.J. Lu <hjl.tools@gmail.com>:
>> On Tue, Nov 19, 2013 at 5:31 AM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote:
>>> Hi All,
>>>
>>> We found out that compiler configured with '-fpmath=sse' option does
>>> not generate scalar floating-point instructions present in the SSE
>>> instruction set for generic32 that leads to performance degradation
>>> for Fortran benchmarks using library functions in 32-bit mode.
>>>
>>> This simple fix was designed to cure this issue - definition of
>>> TARGET_FPMATH_DEFAULT_P macros was missed in i386/ssemath.h. Also one
>>> missed fix was done.
>>>
>>> Bootstrapping and regression testing were successful.
>>>
>>> Is it OK for trunk
>>>
>>> 2013-11-20 Yuri Rumyantsev <ysrumyan@gmail.com>
>>>
>>> * config/i386/i386.c (ix86_option_override_internal): Add missed
>>> argument prefix for 'ix86_fpmath'.
>>> * config/i386/ssemath.h: Add missed definition of
>>> TARGET_FPMATH_DEFAULT_P macros.
The patch looks OK to me, but let's also ask Sriraman for his opinion.
Thanks,
Uros.